Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor actions' arguments #19

Closed
wants to merge 2 commits into from
Closed

Conversation

blocknotes
Copy link
Owner

@blocknotes blocknotes commented Mar 10, 2022

⚠️ Breaking changes ⚠️

  • actions arguments now must be placed in args key
    • example data: { if: "checked", then: "addClass", args: "red", target: "#something" }
  • callbacks functions now must be placed in callback key, optionally with arguments in args key
    • example data: { if: "checked", then: "callback", callback: "setTitle", args: "Some title" }

@blocknotes blocknotes added this to the 1.0 milestone Mar 10, 2022
@blocknotes blocknotes self-assigned this Mar 10, 2022
Base automatically changed from operator-not to master March 11, 2022 10:33
@blocknotes blocknotes force-pushed the refactor-actions-arguments branch from 9e83c83 to bb2916f Compare March 11, 2022 10:34
@blocknotes blocknotes mentioned this pull request Mar 11, 2022
@blocknotes blocknotes force-pushed the refactor-actions-arguments branch from bb2916f to 6720e5d Compare March 12, 2022 15:13
@blocknotes blocknotes force-pushed the refactor-actions-arguments branch 2 times, most recently from a137dbf to 22ac144 Compare March 12, 2022 21:05
@blocknotes blocknotes mentioned this pull request Mar 12, 2022
@blocknotes blocknotes force-pushed the refactor-actions-arguments branch from 22ac144 to 945ba8b Compare March 13, 2022 09:55
@blocknotes blocknotes mentioned this pull request Mar 21, 2025
@blocknotes
Copy link
Owner Author

Already implemented with a different solution (#30)
Closing

@blocknotes blocknotes closed this Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant