-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor and implement IRIs #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatype by wrapping Uri
…ious parts of the Uri
…map returned by _parseAndNormalize to apply Punycode conditionally in IRI class
…on and format / tidy code in IRI class
…ccessors with documentation and to ensure they decode various components from the underlying Uri class as required
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRIs are now their own standalone class and implementation that aligns closely with the RFC 3987 specification. They use Dart's native Uri class as their underlying representation and perform the IRI <-> URI mapping algorithms.
This is now decoupled from the idea of IRIs are one of the kinds of RDF term types which is now it's own class as well.