[Demo] Add BIP322 implementation #1893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aagbotemi please rebase this PR to fix the CI issues. Also this is a pretty big PR that will need careful review due to the use of private keys. Please be patient as it will take some time to get proper reviews done. Thanks! |
aagbotemi
force-pushed
the
feature/bip322-support
branch
from
f2405e8 to
eded159
Compare
|
Hi @notmandatory. I have rebased this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the BIP322 standard for generic signed message in Bitcoin
Features
Notes to the reviewers
This PR is intended as demonstration of BIP322 and it is open for feedback
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: