Migrate FeeRate to procedural macros #693
Merged
+16
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1469,19 +1469,7 @@ interface Amount { | |||
| f64 to_btc(); | |||
| }; | |||
|
|
|||
| interface FeeRate { | |||
There was a problem hiding this comment.
Should we have sort of policy when migrating to proc macros, if a type did not have documentation defined, a second commit introduces docs too? Seems like a good opportunity to get those out of the way
There was a problem hiding this comment.
I think that's a great idea.
thunderbiscuit
force-pushed
the
feature/macros-2
branch
from
5fd3c71 to
7563a25
Compare
thunderbiscuit
force-pushed
the
feature/macros-2
branch
from
7563a25 to
74761d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply migrates the FeeRate type to procedural macros. Notice that because it is used in the UDL more places than simply its definition, we must keep a single line indicating its definition in proc macros.
These lines can be removed once no reference to the FeeRate type are required in the UDL (for example once we migrate the
Wallettype).I also fixed here the arguments to both constructors of the
FeeRatetype to bring them in line with the Rust API.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing