Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster conditional sampling for multiple rows #20

Merged
merged 67 commits into from
May 24, 2024
Merged

Faster conditional sampling for multiple rows #20

merged 67 commits into from
May 24, 2024

Conversation

jkapar
Copy link
Collaborator

@jkapar jkapar commented Feb 14, 2024 •
edited by mnwright
Loading

  • Vectorized conditional sampling ("separate" and "or")
  • Handling of unobserved categories by alpha parameter in train
  • Option to sample NAs according to occurence in original data (NA_share stored in forde params)
  • To do: Implement David's options for entering conditions
  • lik function has not been modified

@mnwright
Copy link
Member

mnwright commented Feb 15, 2024 •
edited
Loading

Can we remove the R/Conditional_JK directory from the PR? my fault, already done.

@mnwright mnwright mentioned this pull request Feb 26, 2024
Merged
mnwright
mnwright reviewed Apr 29, 2024
View reviewed changes
mnwright and others added 20 commits May 7, 2024 10:55
This was referenced May 17, 2024
Closed
Closed
Closed
Closed
@mnwright mnwright merged commit 9ff0f5c into main May 24, 2024
6 checks passed
@mnwright mnwright deleted the conditional_sampling_jk branch May 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnwright mnwright mnwright left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkapar @mnwright @PegahGolchian