fix all NA condition rows bug

bips-hb · Mar 1, 2024 · 0da0b5a · 0da0b5a
1 parent 9af0a8f
commit 0da0b5a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/R/forde.R b/R/forde.R
@@ -156,7 +156,7 @@ forde <- function(
         max_j <- max(x[[j]], na.rm = TRUE)
         gap <- max_j - min_j
         lb[, j] <- min_j - epsilon / 2 * gap
-        ub[, j] <- max_j #+ epsilon / 2 * gap
+        ub[, j] <- max_j + epsilon / 2 * gap
       }
     }
     for (i in 1:num_nodes) {

diff --git a/R/forge.R b/R/forge.R
@@ -79,7 +79,7 @@
 #' @importFrom foreach foreach %dopar%
 #' @importFrom truncnorm rtruncnorm 
 #' @importFrom stats rbinom
-#' 
+#'
 
 forge <- function(
     params, 
@@ -120,6 +120,9 @@ forge <- function(
       index_end <- min(step_*stepsize_foreach, nrow(condition))
       condition_part <- condition[index_start:index_end,]
       cparams <- cforde(params, condition_part, condition_row_mode, stepsize)
+      if(is.null(cparams)) {
+        n_synth <- n_synth * nrow(condition_part)
+      }
     } else {
       cparams <- NULL
     }

diff --git a/R/utils.R b/R/utils.R
@@ -540,6 +540,7 @@ cforde <- function(params, condition, row_mode = c("separate", "or"), stepsize =
   }
   if(row_mode == "separate" & (nconds != nconds_conditioned)) {
     conds_unconditioned <- (1:nconds)[!(1:nconds) %in% conds_conditioned]
+    forest_new <- forest_new[!(c_idx %in% conds_unconditioned),] 
     forest_new_unconditioned <- copy(forest)
     forest_new_unconditioned <- rbindlist(replicate(length(conds_unconditioned), forest, simplify = F))
     forest_new_unconditioned[, `:=` (c_idx = rep(conds_unconditioned,each = nrow(forest)), f_idx_uncond = f_idx, cvg_arf = cvg)]