refactor: drop DynRef and move fs into Workspace
#4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
arendjr
commented
Nov 9, 2024
| &mut console, | ||
| Args::from([("check"), "--write", file.as_os_str().to_str().unwrap()].as_slice()), | ||
| Args::from(["check", "--write", file.as_os_str().to_str().unwrap()].as_slice()), |
There was a problem hiding this comment.
Note: I ran a search-and-replace on the args to remove these odd parentheses. My refactor had to touch all these call sites anyway, so I figured it was a good time to do this. This probably resulted in most of the reduction in line count in this PR.
CodSpeed Performance ReportMerging #4493 will not alter performanceComparing Summary
|
ematipico
approved these changes
Nov 11, 2024
| // Q: We can't use a real filesystem here, but is the memory | ||
| // filesystem the right choice? It might be, since I guess it | ||
| // will allow us to inject plugins if we wanted to. | ||
| inner: workspace::server(Box::new(MemoryFileSystem::default())), |
There was a problem hiding this comment.
Yeah it should be safe to use the memory file system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The reason
DynRefexisted was primarily because of tests: It allowed for dynamic ownership which was used to let theSessionown thefsunder normal execution, which in tests the test owned thefsfor snapshot purposes. With this PR, theWorkspacehas become the owner of thefs, while everywhere else we use references. To resolve the situation in the tests, I've wrapped thefilesof theMemoryFileSystemin anArc, which allows me to reconstruct theMemoryFileSystemfor the snapshot, even though the original instance was consumed during the test run.The reason I wanted to place the
fsintoWorkspaceis so that we can start doing I/O from inside the workspace server, which this solution also allows for.Test Plan
CI should remain green.