Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] addons: Use QTimer.singleShot to exit/restart #326

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

ales-erjavec
Copy link
Collaborator

@ales-erjavec ales-erjavec commented Mar 21, 2025

Issue

Fix #325 (or at least attempt workaround)

Changes

Queue the exit call instead of calling it directly. This seems to fix the issue, but I am not sure why.

The problem is that the whole sequence of dialogs and installation happens before the application even enters the main event loop (QApplication.exec). Only QDialog.exec are on the stack. To properly fix this we should move the loading of workflows that are present on the command line to after the application enters the main loop.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.46%. Comparing base (e9297c5) to head (2998105).

Files with missing lines Patch % Lines
orangecanvas/application/addons.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   76.47%   76.46%   -0.01%     
==========================================
  Files         102      102              
  Lines       21248    21248              
==========================================
- Hits        16249    16247       -2     
- Misses       4999     5001       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd janezd merged commit df6d5fe into biolab:master Mar 21, 2025
21 checks passed
@ales-erjavec ales-erjavec deleted the fixes/restart branch March 24, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed add-on installation(?) and later problems with some workflows
3 participants