Fix missing argument and failed test

bilcus · Jul 31, 2018 · 8dfbdcb · 8dfbdcb
1 parent f9966d2
commit 8dfbdcb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/samlsp/middleware.go b/samlsp/middleware.go
@@ -141,7 +141,7 @@ func (m *Middleware) RequireAccount(handler http.Handler) http.Handler {
 
 		m.ClientState.SetState(w, r, relayState, signedState)
 		if binding == saml.HTTPRedirectBinding {
-			redirectURL := req.Redirect(relayState)
+			redirectURL := req.Redirect(relayState, m.ServiceProvider.EntityID)
 			w.Header().Add("Location", redirectURL.String())
 			w.WriteHeader(http.StatusFound)
 			return

diff --git a/service_provider_test.go b/service_provider_test.go
@@ -779,7 +779,7 @@ func (test *ServiceProviderTest) TestInvalidAssertions(c *C) {
 
 	assertion.Conditions.AudienceRestrictions[0].Audience.Value = "not/our/metadata/url"
 	err = s.validateAssertion(&assertion, []string{"id-9e61753d64e928af5a7a341a97f420c9"}, TimeNow())
-	c.Assert(err.Error(), Equals, "Conditions AudienceRestriction does not contain \"https://15661444.ngrok.io/saml2/metadata\"")
+	c.Assert(err.Error(), Equals, "Conditions AudienceRestriction does not contain \"https://15661444.ngrok.io/saml2/metadata\" or \"\"")
 	assertion = Assertion{}
 	xml.Unmarshal(assertionBuf, &assertion)
 }