-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NextRequest auth #182 Mendo SO #169 #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid changes! V concise and straightforward. Left one non-blocking suggestion for the docs
@@ -213,6 +218,8 @@ Below is an example from `ca_san_diego_pd.json` metadata JSON. | |||
] | |||
``` | |||
|
|||
For an example of authentication handling, see `ca_mendocino_county_sheriff.json`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some more details? Should contribs generate that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry, not sure what you're asking for here?
Description
This builds out authentication for NextRequest sites and also builds out a Mendocino County sheriff's office scraper.
Summary of Changes
This provides a means for authentication to be handled with NextRequest sites.
It provides an initial operating capability for auth data to be included into the metadata.
It also builds out Mendocino County Sheriff as more than a one-off.
It documents the new auth format in metadata
It adds and enables such a format within clean/utils.py
Related Issues
#182 NextRequest auth handling
#169 Build ca_mendocino_county_sheriff
https://github.com/biglocalnews/clean-prefect/issues/42 Bring
auth
data into clean-prefect asset scraping#189 Bring
auth
data into clean-scraper scrape-agency workflowHow to Review
Examples include but are not limited to:
Notes