Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextRequest auth #182 Mendo SO #169 #188

Merged
merged 7 commits into from
Feb 6, 2025
Merged

NextRequest auth #182 Mendo SO #169 #188

merged 7 commits into from
Feb 6, 2025

Conversation

stucka
Copy link
Contributor

@stucka stucka commented Jan 21, 2025

Description

This builds out authentication for NextRequest sites and also builds out a Mendocino County sheriff's office scraper.

Summary of Changes

  • This provides a means for authentication to be handled with NextRequest sites.

  • It provides an initial operating capability for auth data to be included into the metadata.

  • It also builds out Mendocino County Sheriff as more than a one-off.

  • It documents the new auth format in metadata

  • It adds and enables such a format within clean/utils.py

Related Issues

#182 NextRequest auth handling

#169 Build ca_mendocino_county_sheriff

https://github.com/biglocalnews/clean-prefect/issues/42 Bring auth data into clean-prefect asset scraping

#189 Bring auth data into clean-scraper scrape-agency workflow

How to Review

Examples include but are not limited to:

  • Bunch of moving parts on this one.

Notes

@stucka stucka requested a review from newsroomdev January 29, 2025 19:10
Copy link
Member

@newsroomdev newsroomdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid changes! V concise and straightforward. Left one non-blocking suggestion for the docs

@@ -213,6 +218,8 @@ Below is an example from `ca_san_diego_pd.json` metadata JSON.
]
```

For an example of authentication handling, see `ca_mendocino_county_sheriff.json`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some more details? Should contribs generate that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry, not sure what you're asking for here?

@stucka stucka merged commit c686c81 into dev Feb 6, 2025
7 checks passed
@stucka stucka deleted the nextrequest-182 branch February 6, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants