Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

come current with upstream/master so we can bump stdlib #9

Closed
wants to merge 375 commits into from

Conversation

motivator
Copy link

What/Why

We rely on @mhagstrand's addition to this module — 36fe9f6 — which still has an open/un-merged upstream MR — voxpupuli#511. In my effort to bump up our puppetlabs-stdlib version this change brings up up to the current master from https://github.com/voxpupuli/puppet-php and pulls in that change.

Impact

This newer module version will not be used I merge this MR and update the ref in our Puppetfile/Puppetfile.lock files in our puppet repo

Since it's so long, I'll give some crib notes....

bastelfreak and others added 30 commits February 3, 2018 11:12
This version automatically installs the apt-transport-https package,
which is needed for https mirrors. By using this module in at least this
version, we don't need to manage the package on our own.
this is the lowest supported version for ensure_packages
this is a private class, it won't get called directly, only from within
the main class. It references variables from the main class, so we
need to include it (or move the tests into the testfile for the main
class)
…ency

fix composer auto_update idempotency in case no update is available
this fixes an error that was introduced in 0ad7566
software-properties-common is needed to add ppas on ubuntu. the
puppetlabs-apt module can manage the package. it is save to enable this,
because the module uses ensure_package: https://github.com/puppetlabs/puppetlabs-apt/blob/df40baebedf5c0c15e08f3ec78adfd760b1371ca/manifests/ppa.pp#L30

Without this, managing ppa repos at least on ubuntu 16.04 is impossible. I noticed this bug while testing with aceptance tests in voxpupuli#418
manage software-properties-common on ubuntu
bastelfreak and others added 27 commits April 25, 2020 15:43
remove www pool from defaults
modulesync 3.0.0 & puppet-lint autofix
this is a dependency from the apt module. we need to pull it in.
Drop EOL Debian 7/8 & Ubuntu 12/14
Some configuration options (e.g. 'listen_owner', 'listen_group',
'listen_mode', and maybe some more) do not apply by reloading
'php-fpm.service' but require a proper restart.
Signed-off-by: Simon Deziel <[email protected]>
Add apparmor_hat support to php::fpm::pool
By default, this module uses a reload for the php-fpm service. This is
nice because it ensures that there is no downtime. But this is also bad
because certain configuration options, like unix socket owner/group will
only be changed during a restart.

Fixes: voxpupuli#596
Replaces: voxpupuli#597
php-fpm: Make service reload/restart configurable
@motivator motivator closed this Oct 5, 2020
@motivator motivator deleted the v7.1.1-rc0bc1 branch October 6, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.