Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #153 (JDK 21+ compatibility) #154

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

xzel23
Copy link

@xzel23 xzel23 commented Jul 19, 2024

This PR fixes #153:

  • update ASM to 9.7 (already "knows" about Java 23 and will probably work with that version once it's released)
  • update Gradle wrapper to 8.9 (I still can compile with JDK 11, so I hope that's fine)
  • update all other dependencies to the latest versions (except the log4j version in the samples; and not requiring groovy 4)

@xzel23 xzel23 mentioned this pull request Jul 19, 2024
@PerryCameron
Copy link

Ah this is why it wasn't working with 21. Why no merge yet after 3 months?

@xzel23
Copy link
Author

xzel23 commented Oct 11, 2024

@PerryCameron I think the original maintainer, @siordache, simply does not have time to regularly update the project anymore. He asked for co-maintainers a while ago and someone stepped up, but it seems that person also has abandoned the project.

I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again).

I didn't step up as a co-maintainer back then because this project is mainly Groovy and I am really a noob in that language, but maybe I should have. In the meantime, I have volunteered to become a co-maintainer, but @siordache did not reply yet.

@danielpeintner
Copy link

I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again).

That sounds very promising 👍, Thanks!
Did you do so already?

@xzel23
Copy link
Author

xzel23 commented Oct 18, 2024

Thank you! Not yet. It's on my list. I will post here when it's done.

@xzel23
Copy link
Author

xzel23 commented Oct 19, 2024

@danielpeintner I have released a patched version of the plugin to plugin central. To use it, change the plugin id in your gradle build script fom org.beryx.runtime to com.dua3.gradle.runtime and if you also need the plugin version, I bumped it from 1.13.1 to 1.13.1-patch-1. I ha ve tested it with my own JDK 21 project, but JDK 23 should probably work too.

Please report back if something doesn't work.

And if it's of interest to anyone, I have done the same for the sister-plugin Badass-Jlink-Plugin.

Sources for my patched version of the plugin: https://github.com/xzel23/badass-runtime-plugin
Sources for the JLink plugin: https://github.com/xzel23/badass-jlink-plugin

@danielpeintner
Copy link

Please report back if something doesn't work.

Thank you a lot! It worked nicely 👍.
FYI: I am using JDK21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin for Java 21+ compatibility
3 participants