Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure helm chart can run on Kubernetes >= v1.25 and improve installation steps #1196

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

JoeyC-Dev
Copy link
Contributor

@JoeyC-Dev JoeyC-Dev commented Nov 4, 2024

Proposed changes:

  1. Replace helm install with helm upgrade --install, which can be used on both initial installation and upgradation scenarios.
  2. Migrate old API to the latest API and add compatibility with old API: autoscaling/v2beta1

Supporting point:

  • It is easier to use if using helm upgrade --install
  • "The autoscaling/v2beta1 API version of HorizontalPodAutoscaler is no longer served as of v1.25." (src: Deprecated API Migration Guide - v1.25 - HorizontalPodAutoscaler) Meantime, v1.24 is EOL 16 months ago. (src: Non-Active Branch history)
    Today if we are using current version of helm chart, it will fail to run if HPA is enabled as the old API is being deleted since v1.25.
    joey [ ~/whoogle-search ]$ helm upgrade --install whoogle ./charts/whoogle
    Error: UPGRADE FAILED: resource mapping not found for name: "whoogle" namespace: "" from "": no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1"
    ensure CRDs are installed first
  • Make autoscaling/v2 targeting v1.23 as autoscaling/v2 is available since v1.23.

Copy link
Owner

@benbusby benbusby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long with this. Thank you for contributing!

@benbusby benbusby merged commit 5218d97 into benbusby:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants