Fix docs build #5492
Merged
Fix docs build #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like readthedocs build expects docs dependencies to be available as an extra, see one of the failing builds: https://app.readthedocs.org/projects/beets/builds/26079213/. You can see this has been failing due to missing 'pydata_sphinx_theme': raise ThemeError(__('no theme named %r found (missing theme.toml?)') % name) sphinx.errors.ThemeError: no theme named 'pydata_sphinx_theme' found (missing theme.toml?) Theme error: no theme named 'pydata_sphinx_theme' found (missing theme.toml?)
snejus
force-pushed
the
fix-docs-build
branch
2 times, most recently
from
e5b6aa6
to
07529cb
Compare
This was a very bad idea since this made CI operate within the context of the *base* branch, which meant that the tests were testing code in the `master` branch instead of the branch that was to be merged!
snejus
force-pushed
the
fix-docs-build
branch
from
07529cb
to
6180ce1
Compare
|
The two failing checks are from the workflow that used Thus the last commit reverts the commit that introduced |
Serene-Arc
approved these changes
Oct 31, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like readthedocs build expects docs dependencies to be available
as an extra, see one of the failing builds: https://app.readthedocs.org/projects/beets/builds/26079213/.
You can see this has been failing due to missing 'pydata_sphinx_theme' which is one of our dependencies: