ATI Analytics Puppeteer Tests #12515
Draft
+1,077
−577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
commented
Mar 13, 2025
| @@ -32,7 +32,7 @@ const getServiceBundleRegex = service => { | |||
| } | |||
| }; | |||
|
|
|||
| describe('Js bundle requests', () => { | |||
| describe.skip('Js bundle requests', () => { | |||
There was a problem hiding this comment.
Temporarily skip these tests are they are SLOW
karinathomasbbc
changed the title
karinathomasbbc
commented
Mar 14, 2025
Comment on lines
+55
to
+60
| # TEMP: fail faster on CI | ||
| # - name: Run AMP Validator | ||
| # run: yarn amp:validate | ||
|
|
||
| - name: Run Lighthouse | ||
| run: yarn lighthouse | ||
| # - name: Run Lighthouse | ||
| # run: yarn lighthouse |
There was a problem hiding this comment.
Don't forget to put this back!
Suggested change
| # TEMP: fail faster on CI | |
| # - name: Run AMP Validator | |
| # run: yarn amp:validate | |
| - name: Run Lighthouse | |
| run: yarn lighthouse | |
| # - name: Run Lighthouse | |
| # run: yarn lighthouse | |
| - name: Run AMP Validator | |
| run: yarn amp:validate | |
| - name: Run Lighthouse | |
| run: yarn lighthouse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [number]
Overall changes
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines