Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATI Analytics Puppeteer Tests #12515

Draft
wants to merge 40 commits into
base: latest
Choose a base branch
from
Draft

Conversation

karinathomasbbc
Copy link
Contributor

Resolves JIRA [number]

Overall changes

A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.

Code changes

  • A bullet point list of key code changes that have been made.

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@@ -32,7 +32,7 @@ const getServiceBundleRegex = service => {
}
};

describe('Js bundle requests', () => {
describe.skip('Js bundle requests', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily skip these tests are they are SLOW

@karinathomasbbc karinathomasbbc changed the title ATI Analytics Puppetteer Tests ATI Analytics Puppeteer Tests Mar 13, 2025
Comment on lines +55 to +60
# TEMP: fail faster on CI
# - name: Run AMP Validator
# run: yarn amp:validate

- name: Run Lighthouse
run: yarn lighthouse
# - name: Run Lighthouse
# run: yarn lighthouse
Copy link
Contributor Author

@karinathomasbbc karinathomasbbc Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to put this back!

Suggested change
# TEMP: fail faster on CI
# - name: Run AMP Validator
# run: yarn amp:validate
- name: Run Lighthouse
run: yarn lighthouse
# - name: Run Lighthouse
# run: yarn lighthouse
- name: Run AMP Validator
run: yarn amp:validate
- name: Run Lighthouse
run: yarn lighthouse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants