Cypress-tests-transliteration-script-switching

[MeriemMechri]

Resolves JIRA [WORLDSERVICE-106]

Overall changes

• Unskipped and fixed the flakiness for transliteration/script switching.
• Updated fixture data for the following services: Uzbek, Serbia, zohongwen.
• Removed onDemandAudio tests.

Testing

• PR checks passing

• Smoke Tests passing on test: CYPRESS_APP_ENV=test yarn cypress:interactive

• Smoke Tests passing on live: CYPRESS_APP_ENV=live yarn cypress:interactive

• Non-Smoke Tests (Scheduled E2Es) passing on test: CYPRESS_SMOKE=false CYPRESS_APP_ENV=test yarn cypress:interactive

• Non-Smoke Tests (Scheduled E2Es) passing on live: CYPRESS_SMOKE=false CYPRESS_APP_ENV=live yarn cypress:interactive

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

[karinathomasbbc]

We can fix the broken integration tests by running yarn test:integration:updatesnapshots (which have failed because we've updated the fixture data used by some of these tests).

[karinathomasbbc]

Should we also remove the routes from the main settings.js file?

[karinathomasbbc]

Also, did we plan to refactor how the tests run to be more like this: #12364?

[LilyL0u]

When I run the tests against test, one of the tests has a problem where when it is looking for the first <a> on the page to visit the next page in the user journey, it is including the cookie banner <a> in it, because for some reason the cookie banner pops up on this page! This means the next test then fails as it goes to https://www.bbc.co.uk/userinfo which doesn't have the elements we are expecting on it.

So we need to work out a fix for this for it to not fail in the test e2es.

[LilyL0u]

When I ran the tests locally and on test I noticed that (like we were talking about this morning) the article pages clicked on locally always go to an error page, and then the script switch tests run on the error page. They are then not failing because the test then just checks the script switch works, and it does work on error pages, but it means locally and on test it is not testing article pages work with the script switch, just a lot of error page tests!

However, on live it does click valid article pages, and so the tests do run on article pages on live. Do we mind that article pages are not having the script switch checked on local and test, as long as they are covered on live?

[LilyL0u]

When I run the tests against test, one of the tests has a problem where when it is looking for the first <a> on the page to visit the next page in the user journey, it is including the cookie banner <a> in it, because for some reason the cookie banner pops up on this page! This means the next test then fails as it goes to https://www.bbc.co.uk/userinfo which doesn't have the elements we are expecting on it.

So we need to work out a fix for this for it to not fail in the test e2es.

I also ran against live and had the same issue BUT I realised this only happens the first time I run the tests. The next time I run the tests it doesn't happen (probably related to the cookie banner behaviour beign different after first visit). So the question is will this accidential cookie banner click happen in the AWS E2E runs, or not? Does this make the test flakey or does it never do this 🤔

[MeriemMechri]

@karinathomasbbc when I ran this command yarn test:integration:updatesnapshots I got the following failures. Is there a pagetype that I need to add?

[karinathomasbbc]

@karinathomasbbc when I ran this command yarn test:integration:updatesnapshots I got the following failures. Is there a pagetype that I need to add?

Oh dear, not sure why that happened - let me see if it happens to me? Make sure you're not already running yarn dev for Simorgh / NextJS. Did it manage to generate snapshots for Simorgh page types? That might just be enough, since no Next JS pages are impacted by this PR.