-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress-tests-transliteration-script-switching #12500
base: latest
Are you sure you want to change the base?
Cypress-tests-transliteration-script-switching #12500
Conversation
…tests-transliteration-script-switching
…tests-transliteration-script-switching
…tests-transliteration-script-switching
…tests-transliteration-script-switching
…tests-transliteration-script-switching
We can fix the broken integration tests by running |
@@ -21,6 +21,7 @@ Object.keys(config) | |||
.filter( | |||
pageType => | |||
serviceHasPageType(serviceId, pageType) && | |||
pageType !== 'onDemandAudio' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove the routes from the main settings.js file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, did we plan to refactor how the tests run to be more like this: #12364?
cypress/e2e/specialFeatures/utilities/scriptSwitchingJourneyActions/index.js
Outdated
Show resolved
Hide resolved
cypress/e2e/specialFeatures/utilities/scriptSwitchingJourneyActions/index.js
Outdated
Show resolved
Hide resolved
cypress/e2e/specialFeatures/utilities/scriptSwitchingJourneyAssertions/index.js
Outdated
Show resolved
Hide resolved
When I run the tests against test, one of the tests has a problem where when it is looking for the first ![]() So we need to work out a fix for this for it to not fail in the test e2es. |
When I ran the tests locally and on test I noticed that (like we were talking about this morning) the article pages clicked on locally always go to an error page, and then the script switch tests run on the error page. They are then not failing because the test then just checks the script switch works, and it does work on error pages, but it means locally and on test it is not testing article pages work with the script switch, just a lot of error page tests! However, on live it does click valid article pages, and so the tests do run on article pages on live. Do we mind that article pages are not having the script switch checked on local and test, as long as they are covered on live? |
I also ran against live and had the same issue BUT I realised this only happens the first time I run the tests. The next time I run the tests it doesn't happen (probably related to the cookie banner behaviour beign different after first visit). So the question is will this accidential cookie banner click happen in the AWS E2E runs, or not? Does this make the test flakey or does it never do this 🤔 |
@karinathomasbbc when I ran this command ![]() |
Oh dear, not sure why that happened - let me see if it happens to me? Make sure you're not already running yarn dev for Simorgh / NextJS. Did it manage to generate snapshots for Simorgh page types? That might just be enough, since no Next JS pages are impacted by this PR. |
Resolves JIRA [WORLDSERVICE-106]
Overall changes
Testing
PR checks passing
Smoke Tests passing on test: CYPRESS_APP_ENV=test yarn cypress:interactive
Smoke Tests passing on live: CYPRESS_APP_ENV=live yarn cypress:interactive
Non-Smoke Tests (Scheduled E2Es) passing on test: CYPRESS_SMOKE=false CYPRESS_APP_ENV=test yarn cypress:interactive
Non-Smoke Tests (Scheduled E2Es) passing on live: CYPRESS_SMOKE=false CYPRESS_APP_ENV=live yarn cypress:interactive
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines