Changes in example ns according to issue #64

[Gonzih]

According to conversation in issue #64 there is better to use [] in ns declaration after
special forms (:require, :use) since it's clearly describes data. I think same can be
applied to :import and any other form in ns macro.

[bbatsov]

I'm OK with the change, but let's see what others think as well.

[michaelklishin]

I haven't seen the short form used anywhere and [clojure [string :as string]] is pretty objectively confusing. -1 to mentioning the short form at all.

[Gonzih]

https://github.com/ptaoussanis/carmine/blob/master/src/taoensso/carmine/connections.clj

Here is short form in action. People use it not very often, but I think we still should mention it.

[Gonzih]

@michaelklishin I updated my commit, fixed weird situation with string :as string.

[ToBeReplaced]

If we go this direction, I agree with @michaelklishin and would recommend only the long form. This has the added benefits of working in Clojurescript (the short form does not IIRC) and has the least overhead to understand.

[Gonzih]

I didn't thought about ClojureScript version before. Good point, thanks,
added additional commit.

On Sun, 2013-08-18 at 08:40 -0700, ToBeReplaced wrote:

If we go this direction, I agree with @michealklishin and would
recommend only the long form. This has the added benefits of working
in Clojurescript (the short form does not IIRC) and has the least
overhead to understand.

—
Reply to this email directly or view it on GitHub.

Regards,
Max

[Gonzih]

So what now? Should it be merged/rejected? Any changes required?

[michaelklishin]

LGTM now.

[bbatsov]

Yep, LGTM too. Just squash the two commits into one.

[Gonzih]

Done.

On Sat, 2013-08-24 at 11:56 -0700, Bozhidar Batsov wrote:

Yep, LGTM too. Just squash the two commits into one.

—
Reply to this email directly or view it on GitHub.

Regards,
Max