Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create aliases for build dependencies #3229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Create aliases for build dependencies #3229

wants to merge 1 commit into from

Conversation

bakjos
Copy link

@bakjos bakjos commented Jan 31, 2025

This PR tries to fix the issue #3227 by adding the build dependencies as workspace dependency

@HackAttack
Copy link
Contributor

This patch worked for me 👍

UebelAndre
UebelAndre requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a regression test for this?

Also, what is the impact to lockfiles with this change? Does this only impact modules that have [build-dependencies] in a Cargo.toml file?

@bakjos
Copy link
Author

bakjos commented Feb 6, 2025

Thanks @UebelAndre for the feedback, what would be the best place to put the regression test? in one of the existing projects or a new one?, regarding your comment, it will only impact projects with [build-dependencies] which is already failing with the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bakjos @HackAttack @UebelAndre