Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make container image rule compatible with Bazel 8 #2280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justinwon777
Copy link

@justinwon777 justinwon777 commented Jan 27, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

I am able to build container_image with Bazel 8 on this change.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Bazel 8 removes the api to_json() which is used in this file.

What is the new behavior?

Replace it with json.encode()

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

google-cla bot commented Jan 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@justinwon777 justinwon777 changed the title Master Make container image rule compatible with Bazel 8 Jan 27, 2025
@linzhp
Copy link
Collaborator

linzhp commented Jan 28, 2025

The CI is set up to use Bazel 4. We need to change it to Bazel 8 in order to test this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants