Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.6.0] build metrics: Do not set start/end of mnemonics that were only creat… #25598

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Mar 17, 2025

…ed but not executed.

This would previously show confusing metrics such as

  {
    "mnemonic": "FileWrite",
    "firstStartedMs": "10965232776311",
    "lastEndedMs": "1741860739457",
    "actionsCreated": "10"
  },

PiperOrigin-RevId: 737613747
Change-Id: I544f220766c4170318c7f1438584c5613fdc8fa0

Commit bcfd3e7

@meisterT meisterT requested a review from a team as a code owner March 17, 2025 15:36
@meisterT
Copy link
Member Author

Addresses #25593

@meisterT meisterT requested a review from zhengwei143 March 17, 2025 15:37
@meisterT meisterT added the team-Performance Issues for Performance teams label Mar 17, 2025
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Mar 17, 2025
@iancha1992 iancha1992 enabled auto-merge March 17, 2025 16:05
@iancha1992 iancha1992 changed the title build metrics: Do not set start/end of mnemonics that were only creat… [7.6.0] build metrics: Do not set start/end of mnemonics that were only creat… Mar 17, 2025
@iancha1992
Copy link
Member

@meisterT @zhengwei143 Could you please take a look at the presubmit errors? Thanks

…ed but not executed.

This would previously show confusing metrics such as
```
  {
    "mnemonic": "FileWrite",
    "firstStartedMs": "10965232776311",
    "lastEndedMs": "1741860739457",
    "actionsCreated": "10"
  },
```

PiperOrigin-RevId: 737613747
Change-Id: I544f220766c4170318c7f1438584c5613fdc8fa0
@Wyverald
Copy link
Member

The remaining test failure is unrelated to this PR. Please merge #25605 and then rebase this on top.

@iancha1992 iancha1992 added this pull request to the merge queue Mar 18, 2025
Merged via the queue into bazelbuild:release-7.6.0 with commit e882953 Mar 18, 2025
50 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants