Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2.0] Restore compatibility with any JDK 23 on Windows #25349

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

bazel-io
Copy link
Member

-XX:-IgnoreUnrecognizedVMOptions is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming --host_jvm_args.

Fixes #25312

Closes #25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c

Commit 6d64e2e

`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming `--host_jvm_args`.

Fixes bazelbuild#25312

Closes bazelbuild#25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c
@bazel-io bazel-io requested a review from a team as a code owner February 20, 2025 19:32
@bazel-io bazel-io added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website awaiting-review PR is awaiting review from an assigned reviewer labels Feb 20, 2025
@iancha1992 iancha1992 enabled auto-merge February 20, 2025 19:59
@iancha1992 iancha1992 requested a review from hvadehra February 20, 2025 19:59
@iancha1992 iancha1992 added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@iancha1992 iancha1992 added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@iancha1992 iancha1992 added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@iancha1992 iancha1992 added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@meteorcloudy meteorcloudy added this pull request to the merge queue Feb 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2025
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning
of argument parsing and thus can't be used to disable the feature before
consuming `--host_jvm_args`.

Fixes #25312

Closes #25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c

Commit
6d64e2e

Co-authored-by: Fabian Meumertzheim <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2025
@meteorcloudy meteorcloudy added this pull request to the merge queue Feb 25, 2025
Merged via the queue into bazelbuild:release-8.2.0 with commit 878a3ed Feb 25, 2025
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants