Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise default --watchfs event limit #23682

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 19, 2024

By default, the JDK only reports up to 500 events per WatchKey (and thus, per directory). This can be too low in large repos.

Work towards #13226

RELNOTES: On Linux, the default limit on the number of --watchfs file events per directory has been raised to 10,000 (from 500). If needed, it can be increased further via --host_jvm_args=-Djdk.nio.file.WatchService.maxEventsPerPoll=<limit>.

@fmeum fmeum requested a review from meisterT September 19, 2024 11:15
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Sep 19, 2024
@fmeum fmeum marked this pull request as draft September 19, 2024 13:00
@fmeum fmeum marked this pull request as ready for review September 19, 2024 16:56
@fmeum fmeum marked this pull request as draft September 19, 2024 17:04
By default, the JDK only reports up to 500 events per `WatchKey` (and thus, per directory). This can be too low in large repos.

RELNOTES: The default limit on the number of `--watchfs` file events per directory has been raised to 10,000 (from 500). If needed, it can be increased further via `--host_jvm_args=-Djdk.nio.file.WatchService.maxEventsPerPoll=N`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant