Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore compatibility with any JDK 23 on Windows #25342

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 20, 2025

-XX:-IgnoreUnrecognizedVMOptions is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming --host_jvm_args.

Fixes #25312

`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning
of argument parsing and thus can't be used to disable the feature before
consuming `--host_jvm_args`.
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Feb 20, 2025
@fmeum fmeum requested a review from meteorcloudy February 20, 2025 14:18
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 20, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 20, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 20, 2025
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming `--host_jvm_args`.

Fixes bazelbuild#25312

Closes bazelbuild#25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 20, 2025
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning of argument parsing and thus can't be used to disable the feature before consuming `--host_jvm_args`.

Fixes bazelbuild#25312

Closes bazelbuild#25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c
iancha1992 pushed a commit that referenced this pull request Feb 21, 2025
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning
of argument parsing and thus can't be used to disable the feature before
consuming `--host_jvm_args`.

Fixes #25312

Closes #25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c

Commit
6d64e2e

Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2025
`-XX:-IgnoreUnrecognizedVMOptions` is always evaluated at the beginning
of argument parsing and thus can't be used to disable the feature before
consuming `--host_jvm_args`.

Fixes #25312

Closes #25342.

PiperOrigin-RevId: 729186918
Change-Id: Iafe65a6ad8774dcb5605bdfe0adeb17547291b4c

Commit
6d64e2e

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.1.0: Unrecognized VM option 'UseAllWindowsProcessorGroups'
2 participants