Improve flags handling for meson #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2024
Draft
mering
force-pushed
the
meson-flags
branch
3 times, most recently
from
3e692ba to
57a8ef9
Compare
|
I have been able to reproduce the error in a similar build and can confirm that this patch fixes my error, which also was due to the |
|
@voxeljorge @jsharpe could you help me fix the Windows examples build? I don't have this platform available and don't know much about building on it. |
This aligns this to what other tools are doing. This is required to fix --sysroot flag even without cross compiling for example when using in combination with a hermetic toolchain.
mering
force-pushed
the
meson-flags
branch
11 times, most recently
from
760f654 to
9beac98
Compare
jsharpe
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns this to what other tools are doing. The
_join_flags_list()pattern is also used for other foreign build tools.This is required to fix
--sysrootflag even without cross compiling for example when using in combination with a hermetic toolchain (for exampletoolchains_llvm). This flag is only available inget_flags_info()and for the complicated ffmpeg build this works flawlessly. Without it being absolute, it doesn't work.This is required to fix
libdav1din #1295.