Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ONRAMP-5024): Update docs. Add apiKey to onramp utils #2077

Merged
merged 12 commits into from
Mar 31, 2025

Conversation

rustam-cb
Copy link
Contributor

What changed? Why?
Updated documentation to mention apiKey as an optional param in the onramp utils. Added missing iconUrl prop as well
Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • [] docs.base.org
  • [] docs sub-pages

Copy link

vercel bot commented Mar 26, 2025

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 26, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 0:32am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 0:32am

@rustam-cb rustam-cb merged commit 020d3f6 into master Mar 31, 2025
9 checks passed
@rustam-cb rustam-cb deleted the onramp-5024-docs branch March 31, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants