fix: update wallet_connect request to fix createSubAccount capability… #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@montycheese is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
✅ Heimdall Review Status
|
dschlabach
approved these changes
Mar 20, 2025
brendan-defi
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… shape
What changed? Why?
The shape of wallet_connect's addSubAccount capability renamed the signer param to key. This now accurately reflects the ERC spec https://eip.tools/eip/7895
Notes to reviewers
How has it been tested?
Verified locally
Have you tested the following pages?