Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix function MultisigBuilder.sol / NestedMultisigBase.sol #128

Closed
wants to merge 2 commits into from
+3 −3
Closed

fix function MultisigBuilder.sol / NestedMultisigBase.sol #128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f839c
Update MultisigBuilder.sol
futreall Feb 23, 2025
81fe4fe
Update NestedMultisigBase.sol
futreall Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Update NestedMultisigBase.sol
@futreall
futreall authored Feb 23, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 81fe4fef8db0ae70634e50b3709799b7dabeef4f
4 changes: 2 additions & 2 deletions script/universal/NestedMultisigBase.sol
View file
Original file line number Diff line number Diff line change
@@ -109,13 +109,13 @@ abstract contract NestedMultisigBase is MultisigBase {
)
)
);
bytes memory approveHashExec = _execTransationCalldata(
bytes memory approveHashExec = _execTransactionCalldata(
_signerSafe, approveHashData, Signatures.genPrevalidatedSignature(MULTICALL3_ADDRESS)
);
calls[0] = IMulticall3.Call3({target: _signerSafe, allowFailure: false, callData: approveHashExec});

// simulate the final state changes tx, so that signer can verify the final results
bytes memory finalExec = _execTransationCalldata(_safe, _data, Signatures.genPrevalidatedSignature(_signerSafe));
bytes memory finalExec = _execTransactionCalldata(_safe, _data, Signatures.genPrevalidatedSignature(_signerSafe));
calls[1] = IMulticall3.Call3({target: _safe, allowFailure: false, callData: finalExec});

return calls;