Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename postfix param on renderVersionBadge() to suffix; test [wordpress] #10667

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

chris48s
Copy link
Member

This PR renames the postfix param on renderVersionBadge() to suffix.
This brings it into line with the terminology we use elsewhere in the codebase. e.g:

@chris48s chris48s added the core Server, BaseService, GitHub auth, Shared helpers label Nov 10, 2024
Copy link
Contributor

github-actions bot commented Nov 10, 2024

Warnings
⚠️ This PR modified service code for wordpress but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 1c833f3

Copy link
Contributor

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris48s chris48s merged commit 2bd926e into badges:master Nov 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants