fix [githubpipenv] service tests #10658
Conversation
jNullj
added
keep-service-tests-green
jNullj
force-pushed
the
fix/service-test-green/github-pipenv
branch
from
45af635
to
c27637c
Compare
replaced tested package which is missing with another example
jNullj
force-pushed
the
fix/service-test-green/github-pipenv
branch
from
c27637c
to
9a05c6e
Compare
| @@ -83,9 +82,9 @@ t.create('Locked version of unknown dependency') | |||
|
|
|||
| t.create('Locked version of VCS dependency') | |||
| .get( | |||
| '/locked/dependency-version/thorn-oss/perception/dev/videoalignment.json', | |||
| '/locked/dependency-version/metabolize/rq-dashboard-on-heroku/dev/black.json', | |||
There was a problem hiding this comment.
This isn't a VCS dependency it is a pypi dependency, so doing this just makes this replicate another test. We need to find an example of a project using a VCS dependency. Let me see if I can find one.
There was a problem hiding this comment.
So here's a few examples of what we are looking for:
I have no idea how much we can expect any of those examples to remain stable. If this is something that keeps breaking, we could consider converting this test case to a mock or unit test.
There was a problem hiding this comment.
I ended up picking pipenv's locked vcs dependency pypiserver, i assume its a big project and is stable.
also very related to our tests here ;)
The version ref is a commit hash so i added a text-validation for commit hash, i bet it might be useful in the future.
There was a problem hiding this comment.
reasonable choices all round 👍
replaced tested package that changed on remote repo to avoid failure.
as discovered in pr #10656 at this ci test