fix: BTC del Expired and Unbond in same block panics #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
changed the title
RafilxTenfen
added
security
consensus breaking
RafilxTenfen
requested review from
KonradStaniec,
gitferry and
SebastianElvis
RafilxTenfen
commented
Feb 28, 2025
| @@ -142,7 +142,7 @@ func (d *BTCDelegation) GetStatus( | |||
|
|
|||
| // if the endheight is lower than the btc height + unbonding time | |||
| // the btc delegation should be considered expired | |||
| if btcHeight+d.UnbondingTime > d.EndHeight { | |||
| if btcHeight+d.UnbondingTime >= d.EndHeight { | |||
RafilxTenfen
commented
Feb 28, 2025
Comment on lines
+172
to
+182
| _, err = msgSrvrBtcStk.BTCUndelegate(ctx, msgUndelegate) // fails to unbond, since the BTC was expired | ||
| require.EqualError(t, err, bstypes.ErrInvalidBTCUndelegateReq.Wrap("cannot unbond an unbonded BTC delegation").Error(), "should error out") | ||
|
|
||
| // produce block | ||
| _, err = app.EndBlocker(ctx) | ||
| require.NoError(t, err) | ||
|
|
||
| // produces one more block to process the unbonding and it should not halt the chain | ||
| require.NotPanics(t, func() { | ||
| ProduceBlock(t, r, app, ctx) | ||
| }) |
There was a problem hiding this comment.
If the fix was not applied, it would halt the chain https://github.com/babylonlabs-io/babylon/actions/runs/13593223907/job/38004114111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a BTC was about to get expired, but gets unbonded in the same BTC block
in the next babylon block when it was about to process the undelegation event, it would halt in the rewards as the expired event would already had deleted the btc delegation reward tracker information