Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum supported node to 12 #933

Closed
wants to merge 1 commit into from

Conversation

pastelsky
Copy link

@pastelsky pastelsky commented Mar 7, 2022

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Node versions as low as v10 are supported and babel-loader's source code is transpiled heavily to suit older node versions.

What is the new behavior?
Upgrades minimum node version requirement to v12. v12 itself is in maintenance mode and due to be outdated soon — it doesn't make a lot of sense to keep supporting node 10 or below.

Additionally, I've upgraded yarn and regenerated yarn.lock too.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact: Users using node < 12 will no longer be able to run babel-loader
  • Migration path for existing applications: Upgrade to a maintained node version — like Node 12 or above

@pastelsky
Copy link
Author

This unlocks usage of #932

@learn2grid
Copy link

Files changed.

@@ -11,8 +11,8 @@
},
"dependencies": {
"find-cache-dir": "^3.3.1",
"lmdb": "^2.2.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json changes are part of #932, can you revert them and update the lockfile accordingly for this PR?

@@ -3,7 +3,7 @@
["@babel/preset-env", {
"loose": true,
"targets": {
"node": "6.9"
"node": "12.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Let's bump to 12.17.0, the first node 12 version with ESM unflagged.

@JLHwung JLHwung mentioned this pull request Oct 24, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants