-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command-line option to list the supported licenses #30
Conversation
I do not know why it has my previous commits here, and I do not know how to be rid of them. |
src/main.rs
Outdated
} else { | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this else
clause necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, for goodness’ sake. I did fix this on my local repo, but git was not liking me yesterday. No, that else clause is very much not necessary.
That should fix the random else statement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM.
Can you update README too?
https://github.com/azu/license-generator/blob/master/README.md?plain=1#L11-L34
Is that all good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Probably, it is safe that git fetch upstream repo(it is |
Release Release v1.3.0 · azu/license-generator 🎉 |
Does what it says on the tin. Did have to update
structopt
to the latest version though, just to be transparent.You can now run
license-generator --list
and it will simply print out all the licenses given in the LICENSES const variable.If you pass
--list
it doesn't require an INPUT set, but if--list
isn't there, you do