Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line option to list the supported licenses #30

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

Hoverth
Copy link
Contributor

@Hoverth Hoverth commented Sep 5, 2024

Does what it says on the tin. Did have to update structopt to the latest version though, just to be transparent.

You can now run license-generator --list and it will simply print out all the licenses given in the LICENSES const variable.

If you pass --list it doesn't require an INPUT set, but if --list isn't there, you do

@Hoverth
Copy link
Contributor Author

Hoverth commented Sep 5, 2024

I do not know why it has my previous commits here, and I do not know how to be rid of them.

src/main.rs Outdated
Comment on lines 39 to 41
} else {

}
Copy link
Owner

@azu azu Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this else clause necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, for goodness’ sake. I did fix this on my local repo, but git was not liking me yesterday. No, that else clause is very much not necessary.

@Hoverth
Copy link
Contributor Author

Hoverth commented Sep 5, 2024

That should fix the random else statement.

@azu azu added the Type: Feature New Feature label Sep 6, 2024
Copy link
Owner

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hoverth
Copy link
Contributor Author

Hoverth commented Sep 6, 2024

Is that all good?

Copy link
Owner

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azu azu merged commit bbfe023 into azu:master Sep 6, 2024
3 checks passed
@azu
Copy link
Owner

azu commented Sep 6, 2024

I do not know why it has my previous commits here, and I do not know how to be rid of them.

Probably, it is safe that git fetch upstream repo(it is https://github.com/azu/license-generator) and checkout any feature branch before submitting PR.

@azu
Copy link
Owner

azu commented Sep 6, 2024

Release Release v1.3.0 · azu/license-generator 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants