This repository was archived by the owner on Oct 8, 2022. It is now read-only.
project naming + security group ingress #11
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you care to merge this or not but I made a couple modifications that were helpful for me.
I added the naming change because I often have to manage multiple projects and ensuring there isn't naming conflicts is important to me. Also, this gives you granularity at the security group level for multiple projects.
I also added a default group rule so that you don't have to go to console and modify it manually. This might not be ideal for non VPC related deployments but AFAICT this module is meant for VPC deployments so VPC rules should keep it safe, especially if you are deploying to a private subnet as I am.
Let me know if you have any questions, great module - it was very help for me. Thanks!