Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log)!: remove dependency on tendermint #79

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

hazzik
Copy link

@hazzik hazzik commented Feb 18, 2025

Description

This refactor removes the outdated Tendermint dependency, which was previously used only for logging. The changes maintain source compatibility with the previous implementation.

The Setup function now accepts not only the tmlog.Logger interface but also any interface or struct with a compatible structure.

A direct copy of tmlog.Logger was not possible because it is self-referential, and Go does not support covariant return types. To address this, I used generics and split the interfaces to maintain compile-time type safety.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change

Steps to Test

Expected Behaviour

Other Notes

@hazzik hazzik changed the title refactor(logger): remove dependency on tendermint refactor(log): remove dependency on tendermint Feb 18, 2025
@hazzik hazzik changed the title refactor(log): remove dependency on tendermint refactor(log)!: remove dependency on tendermint Feb 18, 2025
@hazzik hazzik requested a review from cgorenflo February 21, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant