Allow clients to define custom callbacks to handle telemetry #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
commented
Oct 23, 2024
aws-hans-pistor
commented
Oct 23, 2024
aws-hans-pistor
force-pushed
the
feat/custom-telemetry-callbacks
branch
from
79131f5 to
98df814
Compare
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
force-pushed
the
feat/custom-telemetry-callbacks
branch
from
3000b47 to
88a2a1f
Compare
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
aws-hans-pistor
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
|
I've rebased back onto upstream's mainline |
Signed-off-by: Hans Pistor <[email protected]>
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
reviewed
Jan 8, 2025
Co-authored-by: Volodkin Vladislav <[email protected]> Signed-off-by: aws-hans-pistor <[email protected]>
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
aws-hans-pistor
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
approved these changes
Jan 9, 2025
muddyfish
approved these changes
Jan 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The failing test seems unrelated |
keremnc
pushed a commit
to keremnc/mountpoint-s3
that referenced
this pull request
Jan 24, 2025
…#1080) ## Description of change Different users of mountpoint will care about different metrics returned for each requests, so allow them to define their own custom handlers for the on_telemetry callback in addition to the default metrics that mountpoint emits. This allows users to do things like: - emit extended request ids ("x-amz-id-2") - When some criteria is met, log out additional information Relevant issues: awslabs#1079 ## Does this change impact existing behavior? No there should be no breaking changes, the only visible change is that there's a new field to the S3ClientConfig which defines the custom telemetry handler ## Does this change need a changelog entry in any of the crates? Just a note in mountpoint-s3-client letting users know this feature now exists --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Hans Pistor <[email protected]> Signed-off-by: aws-hans-pistor <[email protected]> Co-authored-by: Volodkin Vladislav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Different users of mountpoint will care about different metrics returned for each requests, so allow them to define their own custom handlers for the on_telemetry callback in addition to the default metrics that mountpoint emits.
This allows users to do things like:
Relevant issues: #1079
Does this change impact existing behavior?
No there should be no breaking changes, the only visible change is that there's a new field to the S3ClientConfig which defines the custom telemetry handler
Does this change need a changelog entry in any of the crates?
Just a note in mountpoint-s3-client letting users know this feature now exists
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).