Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the numerical values of input features in GConstruct. #1165

Merged
merged 10 commits into from
Feb 14, 2025

Conversation

classicsong
Copy link
Contributor

@classicsong classicsong commented Feb 13, 2025

Issue #, if available:
#1166

Description of changes:
Validate the numerical values during data transformation when debug mode is True.
(GConstruct has already handled the None value in CategoricalTransform and TokenTransform.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@classicsong classicsong requested a review from thvasilo February 13, 2025 07:53
@classicsong classicsong added the draft label only to be used by dev team - skips CI for small changes label Feb 13, 2025
@classicsong classicsong changed the title Add debug mode for gconstruct Validate the numerical values of input features in gconstruct. Feb 13, 2025
@classicsong classicsong changed the title Validate the numerical values of input features in gconstruct. Validate the numerical values of input features in GConstruct. Feb 13, 2025
@classicsong classicsong added 0.4.1 and removed draft label only to be used by dev team - skips CI for small changes labels Feb 13, 2025
Copy link
Contributor

@thvasilo thvasilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM two minor comments

Xiang Song added 2 commits February 13, 2025 12:17
@classicsong classicsong added the ready able to trigger the CI label Feb 13, 2025
@classicsong classicsong merged commit aa0944d into awslabs:main Feb 14, 2025
8 checks passed
@classicsong classicsong deleted the gconstruct-debug-mode branch February 14, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4.1 ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants