Report checksum validation level #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
force-pushed
the
graebm/validate-checksum2
branch
from
5ef741c to
84df01d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3
Description of changes:
Let user know the level of checksum validation performed on the download. In this PR, this 100% relies on the SDK's checksum validation, which only runs on individual chunks, and there are MANY reasons a chunk may not have a checksum.
Better validation would require significant complexity in the Transfer Manager (i.e. calculating full object checksum from chunks), or changes from S3 (i.e. reporting checksums for chunks in more cases). So for now, just report the level of validation performed, and we can pursue improvements on this validation in the future.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.