Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Build and Deploy section for vanilla bash approach #902

Closed
wants to merge 1 commit into from

Conversation

rimutaka
Copy link
Contributor

@rimutaka rimutaka commented Jun 27, 2024

Our build and deploy instructions are focused on cargo lambda which hides a lot of complexity, but I feel like we should provide an explanation of the fundamentals needed to build and deploy Rust lambdas.

This change should help with understanding the basics and reduce issues like #878 and a bunch of others related to AL2/GLIBC.

I added an overview section and made a few tweaks in other parts to remove repetition.
There is still some duplication with the existing content. I'd like to address that in a separate PR.

Feel free to shoot this down. No hard feelings at all.
I can always write a blog post explaining it if you think it does not belong in the README.

Changes:

  • added an overview how to build and deploy without using cargo lambda
  • fixed a typo
  • removed a duplicated statement
  • added a link

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

* added an overview how to build and deploy without using `cargo lambda`
* fixed a typo
@rimutaka rimutaka marked this pull request as ready for review June 27, 2024 09:01
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not agree with these changes. One of the reasons why this runtime has grown in user base is because we've made it really easy to build and deploy with Cargo Lambda. Putting bash as the first option adds complexity. Many new users won't read pass that, and they will be discourage to use this runtime.

@rimutaka
Copy link
Contributor Author

@calavera , David, sorry, I'm not sure what change you requested. Shall I move the pure bash part to the back somewhere?

@calavera
Copy link
Contributor

This change should help with understanding the basics and reduce issues like #878 and a bunch of others related to AL2/GLIBC.

What are the other related AL2/GLIBC issues? so far, the only problem I've seen people bumping into is trying to run their code against an older GLIBC version. If the goal is helping people troubleshoot those issues, I don't think these changes will help, as they don't explain the problem or the solution. It might be more useful to have a "troubleshooting" section where we explain those kind of issues directly.

I'm ok if you want to compliment some other sections below with more details about creating things manually, but I don't want it as the first option as it was the largest pain point that people had when I started maintaining this project two years ago.

@rimutaka rimutaka marked this pull request as draft July 3, 2024 04:02
@rimutaka
Copy link
Contributor Author

Not sure this is needed.

@rimutaka rimutaka closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants