chore: add validation to the ECS Task Metadata #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philasmar
commented
Feb 14, 2024
|
|
||
| // Use a regular expression to validate the characters | ||
| // Valid characters include letters (uppercase and lowercase), numbers, hyphens, and underscores | ||
| Regex validPattern = new Regex(@"^[A-Za-z0-9\-_]+$"); |
There was a problem hiding this comment.
I am on the fence about the use of RegEx and it's performance impact in this context. Any thoughts?
There was a problem hiding this comment.
If I understand this should only ever be called once so it should have negligible performance impact. Also since it should use the Compiled option since it is only being used. Not that you are using it but adding that feedback in case another reviewer suggest it.
normj
approved these changes
Feb 15, 2024
96malhar
suggested changes
Feb 15, 2024
96malhar
reviewed
Feb 15, 2024
96malhar
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
DOTNET-7341
Description of changes:
169.254.170.2By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.