Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secitem branch with latest nw_socket #703

Draft
wants to merge 45 commits into
base: nw_secitem
Choose a base branch
from

Conversation

sbSteveK
Copy link
Contributor

@sbSteveK sbSteveK commented Jan 8, 2025

Test branch merging ongoing changes from nw_socket. This should either be deleted or merged into nw_secitem.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

DmitriyMusatkin and others added 30 commits December 2, 2024 14:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.23%. Comparing base (fd147d1) to head (cc97e64).
Report is 7 commits behind head on nw_secitem.

Files with missing lines Patch % Lines
source/event_loop.c 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           nw_secitem     #703      +/-   ##
==============================================
+ Coverage       79.20%   79.23%   +0.03%     
==============================================
  Files              30       30              
  Lines            6164     6159       -5     
==============================================
- Hits             4882     4880       -2     
+ Misses           1282     1279       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbSteveK sbSteveK changed the base branch from main to nw_secitem January 9, 2025 19:00
@sbSteveK sbSteveK changed the base branch from nw_secitem to nw_socket January 9, 2025 19:13
@sbSteveK sbSteveK changed the base branch from nw_socket to nw_secitem January 9, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants