Kafka connector was throwing null pointer exception when entire record is null, issue fix. #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… null, issue fix.
ejeffrli
reviewed
Feb 7, 2025
Comment on lines
266
to
269
| if (record == null || record.value() == null) { | ||
| LOGGER.warn("[NullRecord] {} Received a null record or record value, offset: {}", splitParameters, record != null ? record.offset() : "unknown"); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
can we move this code block to before spiller.writeRows? Doesn't seem related to the lambda in spiller.writeRows
There was a problem hiding this comment.
Moved to before spiller.writeRows.
ejeffrli
reviewed
Feb 7, 2025
Comment on lines
353
to
356
| if (record == null || record.value() == null) { | ||
| LOGGER.warn("[NullRecord] {} Received a null record or record value, offset: {}", splitParameters, record != null ? record.offset() : "unknown"); | ||
| return 0; // Skip processing this record | ||
| } |
There was a problem hiding this comment.
Moved to before spiller.writeRows.
ejeffrli
reviewed
Feb 7, 2025
Comment on lines
439
to
442
| if (record == null || record.value() == null) { | ||
| LOGGER.warn("[NullRecord] {} Received a null record or record value, offset: {}", splitParameters, record != null ? record.offset() : "unknown"); | ||
| return 0; // Skip processing this record | ||
| } |
There was a problem hiding this comment.
Moved to before spiller.writeRows.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2575 +/- ##
============================================
+ Coverage 60.68% 60.71% +0.03%
- Complexity 3871 3873 +2
============================================
Files 593 593
Lines 22130 22130
Branches 2732 2735 +3
============================================
+ Hits 13430 13437 +7
+ Misses 7398 7385 -13
- Partials 1302 1308 +6 ☔ View full report in Codecov by Sentry. |
chngpe
approved these changes
Feb 11, 2025
ejeffrli
approved these changes
Feb 11, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
- Upgraded Arrow to 18 (#2576) - Fixed Encoding Warning (#2595) - Fix codecov format error (#2594) - Update Code Cov on Daily Validation Tests (#2593) - Allow custom glue endpoint to be used (#2587) - Msk connector was throwing null pointer exception when entire record is null, issue fix. (#2588) - Kafka connector was throwing null pointer exception when entire record is null, issue fix. (#2575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Kafka connector was throwing null pointer exception when it encountered a completely null record. This change resolves that issue.
PFA testing doc for reference.
Kafka NullPointerException Issue Fix.docx
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.