Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove endpoint #2574

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Remove endpoint #2574

merged 1 commit into from
Feb 10, 2025

Conversation

ejeffrli
Copy link
Contributor

@ejeffrli ejeffrli commented Feb 6, 2025

Cleanup and remove endpoint that is not in use - This was part of initial development with connectors working with Glue Connection; currently all tests are by default pointing to production and this is was purely for internal development;

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.71%. Comparing base (f3521ad) to head (c5c0c03).
Report is 42 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2574      +/-   ##
============================================
+ Coverage     60.68%   60.71%   +0.02%     
- Complexity     3871     3872       +1     
============================================
  Files           593      593              
  Lines         22130    22121       -9     
  Branches       2732     2731       -1     
============================================
  Hits          13430    13430              
+ Misses         7398     7390       -8     
+ Partials       1302     1301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbdulR3hman AbdulR3hman self-assigned this Feb 7, 2025
Copy link
Contributor

@AbdulR3hman AbdulR3hman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved; just want @chngpe to confirm that this is not internally used.

@ejeffrli ejeffrli enabled auto-merge (squash) February 10, 2025 16:41
@aimethed aimethed disabled auto-merge February 10, 2025 17:57
@aimethed aimethed merged commit d6e5530 into master Feb 10, 2025
10 checks passed
@aimethed aimethed deleted the remove-endpoint branch February 10, 2025 18:05
github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
  - Remove endpoint (#2574)
  - add package templates (#2571)
  - Upgraded Github Action to JDK 11 (#2586)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.48.0 to 2.48.1 (#2578)
  - build(deps): bump com.google.cloud:google-cloud-storage
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.18.2 to 3.19 (#2579)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier
  - build(deps): bump com.microsoft.azure:msal4j from 1.18.0 to 1.19.0 (#2581)
  - build(deps): bump com.microsoft.azure:msal4j from 1.18.0 to 1.19.0
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.0 to 4.9.1 (#2585)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.23.8 to 2.23.9 (#2582)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.23.8 to 2.23.9
  - build(deps): bump com.oracle.database.jdbc:ojdbc8 from 23.6.0.24.10 to 23.7.0.25.01 (#2583)
  - build(deps): bump com.oracle.database.jdbc:ojdbc8
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.30.11 to 2.30.16 (#2580)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs
  - build(deps): bump aws-sdk-v2.version from 2.30.11 to 2.30.16 (#2577)
  - build(deps): bump aws-sdk-v2.version from 2.30.11 to 2.30.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants