Handle Oracle NUMBER correctly by letting JdbcArrowTypeConverter hand…

[ejeffrli]

Oracle NUMBER with no precision or scale specified allows for Oracle users to have a dynamic number of decimal points. This means NUMBER column can have the value 10.123123 for one entry and 10 for the other entry.

This is not reflected properly in our connector. This fix removes the precision == 0 check (originally, mis-wrote as scale == 0) on line 381 because JdbcArrowTypeConverter.java handles that on line 51. See

aws-athena-query-federation/athena-jdbc/src/main/java/com/amazonaws/athena/connectors/jdbc/manager/JdbcArrowTypeConverter.java

Line 51 in 3afa6ab

boolean needsResolving = jdbcType == Types.NUMERIC && (precision == 0 && scale <= 0);

With above change, customers can now specify default_scale in lambda environment variables to capture the Oracle NUMBER's decimal points.

It also changes line 381 to include 0 to correctly convert 0 scale DECIMAL to arrow BIGINT.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.69%. Comparing base (f3521ad) to head (626bf45).
Report is 22 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...thena/connectors/oracle/OracleMetadataHandler.java	75.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2573      +/-   ##
============================================
+ Coverage     60.68%   60.69%   +0.01%     
  Complexity     3871     3871              
============================================
  Files           593      593              
  Lines         22130    22134       +4     
  Branches       2732     2732              
============================================
+ Hits          13430    13435       +5     
  Misses         7398     7398              
+ Partials       1302     1301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.