Handling array values in Neptune node (#2095)

awslabs · Jul 31, 2024 · 21a6e11 · 21a6e11
1 parent c9be4f5
commit 21a6e11
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/...m/amazonaws/athena/connectors/neptune/propertygraph/rowwriters/CustomSchemaRowWriter.java b/...m/amazonaws/athena/connectors/neptune/propertygraph/rowwriters/CustomSchemaRowWriter.java
@@ -47,6 +47,7 @@
 import java.util.Date;
 import java.util.Map;
 import java.util.TreeMap;
+import java.util.stream.Collectors;
 
 /**
  * This class is a Utility class to create Extractors for each field type as per
@@ -124,7 +125,14 @@ else if (fieldValue instanceof ArrayList) {
                                     else if (fieldValue instanceof ArrayList) {
                                         ArrayList<Object> objValues = (ArrayList) fieldValue;
                                         if (objValues != null && objValues.get(0) != null) {
-                                            value.value = objValues.get(0).toString();
+                                            if (objValues.size() > 1) {
+                                                value.value = String.join(";", objValues.stream()
+                                                        .map(Object::toString)
+                                                        .collect(Collectors.toList()));
+                                            }
+                                            else {
+                                                value.value = objValues.get(0).toString();
+                                            }
                                             value.isSet = 1;
                                         }
                                     }

diff --git a/...ava/com/amazonaws/athena/connectors/neptune/propertygraph/rowwriters/VertexRowWriter.java b/...ava/com/amazonaws/athena/connectors/neptune/propertygraph/rowwriters/VertexRowWriter.java
@@ -45,6 +45,7 @@
 import java.util.Date;
 import java.util.Map;
 import java.util.TreeMap;
+import java.util.stream.Collectors;
 
 /**
  * This class is a Utility class to create Extractors for each field type as per
@@ -96,8 +97,15 @@ public static void writeRowTemplate(RowWriterBuilder rowWriterBuilder, Field fie
                             } 
                             else {
                                 ArrayList<Object> objValues = (ArrayList) obj.get(fieldName);
-                                if (objValues != null && objValues.get(0) != null) {
-                                    value.value = objValues.get(0).toString();
+                                if (objValues != null && !objValues.isEmpty()) {
+                                    if (objValues.size() > 1) {
+                                        value.value = String.join(";", objValues.stream()
+                                                .map(Object::toString)
+                                                .collect(Collectors.toList()));
+                                    }
+                                    else {
+                                        value.value = objValues.get(0).toString();
+                                    }
                                     value.isSet = 1;
                                 }
                             }