call get ice servers when offer is received to avoid stale ice server… #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue of stale ice server credentials but RTCPeerConnection.setConfiguration() is not supported in Firefox. |
lherman-cs
reviewed
Aug 14, 2020
examples/master.js
Outdated
| @@ -122,8 +99,15 @@ async function startMaster(localView, remoteView, formValues, onStatsReport, onR | |||
| master.signalingClient.on('sdpOffer', async (offer, remoteClientId) => { | |||
| console.log('[MASTER] Received SDP offer from client: ' + remoteClientId); | |||
|
|
|||
| // Get ICE server configuration. | |||
| const getIceServerConfigPromise = master.kinesisVideoSignalingChannelsClient | |||
There was a problem hiding this comment.
I think we should await here, and pass the configuration directly to RTCPeerConnection instead of using setConfiguration.
chehefen
force-pushed
the
get-ice-server-at-offer
branch
from
d955a40 to
722a283
Compare
|
So a tradeoff with this approach is that the startup time might be increased due to having to fetch a new ICEServerConfig before the browser can start gathering ICE candidates on the master side.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… credential
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.