New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the sample page to v3 #426

Open

sirknightj wants to merge 1 commit into develop from aws-sdk-js-v3-migration

Contributor

sirknightj commented Mar 7, 2025

Issue #, if available:

Description of changes:

The sample page uses AWS SDK JS v2 to make API calls to KVS.
AWS SDK for JS v2 has end of life upcoming, but...
AWS SDK for JS v3 doesn't provide a <script> import for browser use anymore.
According to their documentation, we will need to build our own.

Therefore, this pull request

Adds the infrastructure to generate the browser script AWS SDK for JS v3.
Replaces the AWS SDK for JS v2 with the v3.
Updates the sample application to use the AWS SDK for JS v3 syntax.

Important

AWS SDK for JS v3 is only used in the application layer, not in the provided SDK.

Testing

Used the new v3 build infrasturcutre to generate the browser script
Checked P2P WebRTC connection on the local setup.
Pressed all the buttons to check all the updated files got called at least once.
Checked WebRTC ingestion (both master and viewer participant paths)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


          Migrate the test page to v3

3b06912

sirknightj added the Samples label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Samples