Extract ConfigLoaders, and add Github config loader for raw user content #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
force-pushed
the
config_loaders
branch
from
bb01b7e to
da64362
Compare
cpyle0819
requested changes
Feb 19, 2025
cpyle0819
approved these changes
Feb 19, 2025
Laren-AWS
approved these changes
Feb 19, 2025
| def languages(self) -> Set[str]: | ||
| languages: Set[str] = set() | ||
| def languages(self) -> List[str]: | ||
| languages: List[str] = [] |
There was a problem hiding this comment.
Why the switch to List?
Although I can't find where languages is used so it might not matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the Config loaders out from several direct "open" calls to a module Loader class. It then adds a requests-backed loader from raw.githubusercontent.com, defaulting to the main branch in -tools. This is pretty flexible with pretty little abstraction cost, and importantly, means that the -tools package's config folder on main is de-facto instant update. This allows us to later extract a -data package.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.