test(/dev): state transitions #5268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilk-aws
requested changes
Jan 23, 2025
|
|
||
| val actual = prepareState.interact(action) | ||
| assertThat(actual.nextState).isInstanceOf(PrepareCodeGenerationState::class.java) | ||
| val nextState = actual.nextState as PrepareCodeGenerationState |
There was a problem hiding this comment.
Can we assert that this sessionState is not the same as the original PrepareCodeGenerationState object? Our issue that resulted in the COE was that the sessionState didn't change between the first PrepareCodeGenerationState (at the beginning) and this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem: The current implementation lacks a test case for tracking state changes during code generation.
Solution: Added a unit test case that covers the state transitions during the code generation process. This new test will ensure that the state changes are correctly handled and maintained throughout the code generation lifecycle.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.