Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(/dev): Exclude gradle-wrapper.jar and add separate build commands #5266

Closed
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
737c56b
feat: allow install, build, and test commands separately
karanA-aws Jan 15, 2025
63765fe
Exclude gradle-wrapper.jar from .gitignore checks
karanA-aws Jan 15, 2025
d845d43
Exclude gradle-wrapper.jar from .gitignore checks
karanA-aws Jan 16, 2025
aeb328b
feat(amazonq): support Dockerfile files in /dev (#5131)
michaellandi Nov 26, 2024
3b2133c
config(amazonq): enable implicit project context ab test (#5124)
Will-ShaoHua Nov 26, 2024
f37dd26
fix(amazonq): download each job's zip to its own directory (#5134)
dhasani23 Nov 26, 2024
ae089d5
fix(amazonq): Normalize generated file paths in feature dev. (#5130)
ctidd Nov 26, 2024
e0e6c39
fix(amazonq): Correct search text for Amazon Q inline suggestion keyb…
leigaol Nov 26, 2024
7e52360
Updating version to 3.42
Nov 27, 2024
d5a00b2
Updating SNAPSHOT version to 3.43-SNAPSHOT
Nov 27, 2024
56b61d4
Display startup and emergency notifications (#5143)
samgst-amazon Nov 29, 2024
d101adb
Fix notification polling race condition (#5142)
samgst-amazon Nov 30, 2024
f442fb9
changelog for #5143 (#5146)
samgst-amazon Dec 2, 2024
86b5a21
re:Invent 2024
samgst-amazon Dec 3, 2024
876d99e
Updating version to 3.43
Dec 3, 2024
70dc5af
Updating SNAPSHOT version to 3.44-SNAPSHOT
Dec 3, 2024
b3b8bf8
Fix 'ActionGroup should be registered using <group> tag' (#5147)
rli Dec 3, 2024
943e9d3
Fix marketplace description incorrectly referring to `/docs` (#5154)
rli Dec 3, 2024
41e7aef
Clean up Q explore UX (#5153)
rli Dec 3, 2024
f8da96c
Fix wildcard import rule allowing java.util.* (#5155)
rli Dec 3, 2024
f8d274a
Fix for Code Fix issue description.
ashishrp-aws Dec 3, 2024
a34c809
Dedupe open tab logic / fix Q Review tab always using same UUID
rli Nov 29, 2024
ec1cb9a
revert
rli Dec 3, 2024
ffc8926
Adding credentialUrl to differentiate the Internal Users vs External …
laileni-aws Dec 3, 2024
654ee62
fix npm dev dependency issues (#5158)
rli Dec 3, 2024
dd44dc3
Fix: catch error when notification file is not found (#5157)
samgst-amazon Dec 3, 2024
6f3b2e6
Fix Code Transform not starting (#5160)
rli Dec 4, 2024
755ca34
Updating version to 3.44
Dec 4, 2024
99fafba
Updating SNAPSHOT version to 3.45-SNAPSHOT
Dec 4, 2024
8ca9e89
Replaced @aws/dexp by @aws/flare in codeowners, as part of the dexp r…
Jurredr Dec 4, 2024
f586668
fix(amazonq): missing `@workspace` command on welcome tab (#5164)
rli Dec 5, 2024
d22a01a
fix(amazonq): Fix for File Review payload and payload generation erro…
ashishrp-aws Dec 5, 2024
66817bc
Fix for codeScanFilterGroup and Filter Icon error. (#5172)
ashishrp-aws Dec 6, 2024
08b95f3
fix(amazonq): Fix for LLM based code issues for file review on window…
ashishrp-aws Dec 6, 2024
2348fcd
fix: Chosing cancel on confirmation no longer deletes profiles (#5167…
rickardsundin Dec 6, 2024
5c52975
Limit number of times user is given Q welcome page (#5152)
rli Dec 6, 2024
d4f4a3a
Update notification endpoint (#5177)
samgst-amazon Dec 6, 2024
cf47357
feat(amazonq): Add acknowledgement button for disclaimer (#5178)
rli Dec 6, 2024
0d74803
Adding requestId for amazonq_utgGenerateTests event (#5181)
laileni-aws Dec 9, 2024
a6d3f96
notification success telemetry (#5179)
samgst-amazon Dec 9, 2024
424d05f
fix(amazonq): show build logs when pre-build fails (#5173)
dhasani23 Dec 9, 2024
59bd5bd
adding telemetry at time of form selection for one or multiple diffs …
ntarakad-aws Dec 9, 2024
205deed
fix(amazon q): adding the start new transformation button after multi…
ntarakad-aws Dec 9, 2024
e458328
fix(amazonq): don't call stopJob API if no job active (#5174)
dhasani23 Dec 9, 2024
b0d9f3c
Updating version to 3.45
Dec 10, 2024
ec529a9
Updating SNAPSHOT version to 3.46-SNAPSHOT
Dec 10, 2024
a03167c
Fix rejected files display inconsistency between VS Code and JetBrain…
siakmun-aws Dec 11, 2024
ac8bc2b
Limit concurrency of prerelease task (#5184)
rli Dec 11, 2024
f9365ce
Add regression test for EDT freeze when Q creds are expired (#4891)
rli Dec 11, 2024
10bcceb
fix(amazonq): reduce frequency of system information polling (#5190)
leigaol Dec 11, 2024
a13ac32
use RemoteResourceResolver in notification polling for etag and PATH …
samgst-amazon Dec 11, 2024
9c2ba98
build(deps): bump nanoid from 3.3.7 to 3.3.8 in /plugins/core/webview…
dependabot[bot] Dec 12, 2024
9569788
fix: move file name to description (#5195)
ctlai95 Dec 12, 2024
69f7c2e
fix(amazonq): align /doc messages with vscode (#5191)
aggagen Dec 12, 2024
cdf1514
Fix chat not retaining history when interaction is through onboarding…
rli Dec 12, 2024
aecb648
feat(amazonq): automatically scroll to fix section (#5198)
ctlai95 Dec 12, 2024
705e6ed
fix(amazonq): clicking on generated test file does not open file diff…
Randall-Jiang Dec 12, 2024
d75f8fb
Fix SSM integ tests (#5202)
rli Dec 13, 2024
829d470
build(deps): bump nanoid in /plugins/amazonq/mynah-ui (#5204)
dependabot[bot] Dec 13, 2024
1027cf2
Update Mynah UI to 4.21.2 (#5203)
rli Dec 13, 2024
8aa8c74
telemetry(amazonq): generateFix metric result (#5199)
ctlai95 Dec 13, 2024
16b0c61
Adds capability to send new context commands to AB groups (#5206)
spfink Dec 14, 2024
9929c9f
Updating version to 3.46
Dec 17, 2024
70dc24c
Updating SNAPSHOT version to 3.47-SNAPSHOT
Dec 17, 2024
321ccd8
fix(amazonq): allow postgresql as target DB (#5209)
dhasani23 Dec 18, 2024
f4d0ce7
chore: Align UX text of document generation with vs code version (#5212)
KevinDing1 Dec 19, 2024
6f75ea1
fix(amazonq): retry S3 upload (#5208)
dhasani23 Dec 19, 2024
8bc0f9a
Move IntelliJ Gradle plugin to 2.2.1 (#5213)
rli Dec 20, 2024
d6c114e
telemetry(amazonq): add metric for transformation type (#5218)
dhasani23 Dec 23, 2024
355a905
telemetry(amazonq): sending metric data in onCodeGeneration (#5205)
siakmun-aws Dec 24, 2024
6c056fb
fix(amazonq): use correct doc link (#5223)
dhasani23 Dec 31, 2024
f90ab2b
Hide notifications is plugin mentioned in the conditions is not insta…
manodnyab Jan 3, 2025
f17c571
telemetry(amazonq): map to the correct scope (#5210)
ctlai95 Jan 3, 2025
8214433
telemetry(amazonq): combine metrics (#5227)
dhasani23 Jan 7, 2025
74e279f
Fix(core): State storage roaming type set to default for notification…
samgst-amazon Jan 7, 2025
a0bc4a1
fix(amazonq): Skip including deleted files for FeatureDev context. (#…
ctidd Jan 7, 2025
94f08bd
Change logic for customization override to not override if user has m…
spfink Jan 7, 2025
aa431d6
fix(amazonq): Correct amazon q documentation updating flow progress t…
KevinDing1 Jan 8, 2025
c21435f
add JetBrains IdeCategory for enterprise telemetry (#5238)
chungjac Jan 8, 2025
82a660b
fix(amazonq): /test fails for files outside project scope (#5237)
ashishrp-aws Jan 8, 2025
fedb74a
Set expiry for dismissed notifications (#5186)
samgst-amazon Jan 8, 2025
3082a93
telemetry(amazonq): remove amazonq_utgGenerateTests metric override (…
chungjac Jan 9, 2025
a18afbb
Fix for Test generation active file info file path check on windows. …
ashishrp-aws Jan 9, 2025
251c57c
fix: remove the incorrect accept and reject buttons while hovering ov…
KevinDing1 Jan 9, 2025
a0599e9
Fix JSR310 serialization error when preparing login panel (#5216)
rli Jan 9, 2025
fc4896c
rename projectContextProvider.query to queryChat (#5234)
Will-ShaoHua Jan 9, 2025
af7f5d5
Updating version to 3.47
Jan 9, 2025
4afc90c
Updating SNAPSHOT version to 3.48-SNAPSHOT
Jan 9, 2025
823f0cc
fix(amazonq): update messaging for /doc (#5243)
vikshe Jan 10, 2025
5bea616
chore: remove unused telemetry method for /doc (#5248)
KevinDing1 Jan 10, 2025
1273a14
fix(amazonq): minor string updates (#5245)
dhasani23 Jan 10, 2025
32153f7
fix(amazonq): add retry on IOException (#5246)
dhasani23 Jan 10, 2025
1448021
Fix test failures caused by mockk not cleaning up (#5207)
rli Jan 10, 2025
ff1226e
fix(amazonq): Fix code generation error when cancelling /doc task (#5…
aggagen Jan 13, 2025
a5487bc
fix(amazonq): auto open build logs (#5255)
dhasani23 Jan 13, 2025
92fe25c
fix(amazonq): add follow up button (#5251)
dhasani23 Jan 14, 2025
56955c8
feat(amazonq): add error message if updated README is too large (#5253)
avi-alpert Jan 14, 2025
430fcc9
fix(amazonqDoc): Generate README for modules that are a part of the p…
mattmcdonald39 Jan 14, 2025
9ba0b6e
fix(amazonq): Error handling and telemetry for Unit test generation. …
laileni-aws Jan 14, 2025
3491254
fix(amazonq): add link to docs (#5257)
dhasani23 Jan 14, 2025
e07578b
fix(amazonq): file premissions are now preserved and mvn and gradle f…
osdemah Jan 14, 2025
6e8795b
feat(inline completion): enhance inline completion supplemental conte…
Will-ShaoHua Jan 14, 2025
a2c0f70
fix(amazonq): loosen search strings (#5260)
dhasani23 Jan 15, 2025
f9bacc4
change active file context limit to 40000(20k before & after) (#5262)
andrewyuq Jan 15, 2025
63dfe3a
fix(amazonq): rely on server-side data to communicate number of code …
siakmun-aws Jan 15, 2025
9c00012
Telemetry(amazonq): Discrepancy between NumOfUnitTestCasesGenerated w…
Randall-Jiang Jan 15, 2025
916c2d3
telemetry(amazonq): invalid zip event (#5265)
ctlai95 Jan 15, 2025
e314c12
telemetry(AmazonQ) ProgrammingLanguage is unknown (#5267)
Randall-Jiang Jan 16, 2025
bc0ed7b
Updating version to 3.48
Jan 16, 2025
fab42e9
Updating SNAPSHOT version to 3.49-SNAPSHOT
Jan 16, 2025
f9473c4
feat(feature dev): Add setting to allow Q to run code and test comman…
willyyhuang Nov 18, 2024
f495d7d
Exclude gradle-wrapper.jar from .gitignore checks
karanA-aws Jan 15, 2025
240cc27
Exclude gradle-wrapper.jar from .gitignore checks
karanA-aws Jan 16, 2025
1a324bb
merge test for gradlle-wrapper.jar file dismissal from .gitignore.
karanA-aws Jan 17, 2025
8b52b85
merge test for gradlle-wrapper.jar file dismissal from .gitignore.
karanA-aws Jan 17, 2025
4ffc179
resolved rebase conflicts.
karanA-aws Jan 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const val FEATURE_EVALUATION_PRODUCT_NAME = "FeatureDev"
const val FEATURE_NAME = "Amazon Q Developer Agent for software development"

@Suppress("MaxLineLength")
const val GENERATE_DEV_FILE_PROMPT = "generate a devfile in my repository. Note that you should only use devfile version 2.0.0 and the only supported command is test, so you should bundle all install, build and test commands in “test”. also you can use public.ecr.aws/aws-mde/universal-image:latest as universal image if you aren’t sure which image to use. here is an example for a node repository (but don't assume it's always a node project. look at the existing repository structure before generating the devfile): schemaVersion: 2.0.0 components: - name: dev container: image: public.ecr.aws/aws-mde/universal-image:latest commands: - id: test exec: component: dev commandLine: \"npm install && npm run build && npm run test\""
const val GENERATE_DEV_FILE_PROMPT = "generate a devfile in my repository. Note that you should only use devfile version 2.0.0 and the only supported commands are install, build and test (are all optional). so you may have to bundle some commands together using '&&'. also you can use \"public.ecr.aws/aws-mde/universal-image:latest\" as universal image if you aren’t sure which image to use. here is an example for a node repository (but don't assume it's always a node project. look at the existing repository structure before generating the devfile): schemaVersion: 2.0.0 components: - name: dev container: image: public.ecr.aws/aws-mde/universal-image:latest commands: - id: install exec: component: dev commandLine: \"npm install\" - id: build exec: component: dev commandLine: \"npm run build\" - id: test exec: component: dev commandLine: \"npm run test\""

// Max number of times a user can attempt to retry a code generation request if it fails
const val CODE_GENERATION_RETRY_LIMIT = 3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ class CodeWhispererProjectCodeScanTest : CodeWhispererCodeScanTestBase(PythonCod
private lateinit var testYaml: VirtualFile
private lateinit var helperPy: VirtualFile
private lateinit var testTf: VirtualFile
private lateinit var gradleFile: VirtualFile

private lateinit var sessionConfigSpy: CodeScanSessionConfig
private lateinit var sessionConfigSpy2: CodeScanSessionConfig
Expand Down Expand Up @@ -63,9 +64,9 @@ class CodeWhispererProjectCodeScanTest : CodeWhispererCodeScanTestBase(PythonCod
fun `test createPayload`() {
val payload = sessionConfigSpy.createPayload()
assertNotNull(payload)
assertThat(payload.context.totalFiles).isEqualTo(10)
assertThat(payload.context.totalFiles).isEqualTo(11)

assertThat(payload.context.scannedFiles.size).isEqualTo(10)
assertThat(payload.context.scannedFiles.size).isEqualTo(11)
assertThat(payload.context.scannedFiles).contains(testYaml, testTf, readMeMd, utilsJs, utilsCs, testJson, testCs, helperPy, helperCs, helpGo)

assertThat(payload.context.srcPayloadSize).isEqualTo(totalSize)
Expand All @@ -80,12 +81,12 @@ class CodeWhispererProjectCodeScanTest : CodeWhispererCodeScanTestBase(PythonCod
filesInZip += 1
}

assertThat(filesInZip).isEqualTo(10)
assertThat(filesInZip).isEqualTo(11)
}

@Test
fun `getProjectPayloadMetadata()`() {
getProjectPayloadMetadata(sessionConfigSpy, 10, totalSize, this.totalLines, CodewhispererLanguage.Csharp)
getProjectPayloadMetadata(sessionConfigSpy, 11, totalSize, this.totalLines, CodewhispererLanguage.Csharp)
}

@Test
Expand All @@ -105,7 +106,7 @@ class CodeWhispererProjectCodeScanTest : CodeWhispererCodeScanTestBase(PythonCod

@Test
fun `e2e happy path integration test`() = runTest {
assertE2ERunsSuccessfully(sessionConfigSpy, project, totalLines, 10, totalSize, 1)
assertE2ERunsSuccessfully(sessionConfigSpy, project, totalLines, 11, totalSize, 1)
}

private fun setupCsharpProject() {
Expand Down Expand Up @@ -373,5 +374,9 @@ class CodeWhispererProjectCodeScanTest : CodeWhispererCodeScanTestBase(PythonCod
// The tests include the markdown file but not these two files.
projectRule.fixture.addFileToProject("/.gitignore", "node_modules\n.idea\n.vscode\n.DS_Store").virtualFile
projectRule.fixture.addFileToProject("test.idea", "ref: refs/heads/main")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change other teams test unless necassary. Change the tests for our team instead. FeatureDevSessionContextTest.kt::testZipProject

gradleFile = projectRule.fixture.addFileToProject("gradle/wrapper/gradle-wrapper.jar", "").virtualFile
totalSize += gradleFile.length
totalLines += gradleFile.toNioPath().toFile().readLines().size
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ class FeatureDevSessionContext(val project: Project, val maxProjectSizeBytes: Lo
suspend fun ignoreFile(file: VirtualFile): Boolean = ignoreFile(file.path)

suspend fun ignoreFile(path: String): Boolean {
// explicitly allow the Gradle wrapper JAR file
if (path.endsWith("gradle/wrapper/gradle-wrapper.jar")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hardcode here. add a list of them at the top. you can say something like private val requiredBinaryFilesForExecution = setOf("gradle/wrapper/gradle-wrapper.jar")

return false
}

// this method reads like something a JS dev would write and doesn't do what the author thinks
val deferredResults = ignorePatternsWithGitIgnore.map { pattern ->
withContext(coroutineContext) {
Expand Down
Loading