Change response types for POJOs that map one to many

[davidh44]

Motivation and Context

There are a handful of POJOs in v1 that map to two types in v2. For instance, v1 AccessControlList is used as input to setObjectAcl(), and also returned as response from getObjectAcl().

In v2, AccessControlPolicy is used as input, while GetObjectAclResponse is returned as the response.

Modifications

Forked ChangeMethodInvocationReturnType recipe from OpenRewrite. It is a newer recipe so requires OR version bump, which introduces breaking changes with existing SDK recipes.

https://github.com/openrewrite/rewrite/blob/main/rewrite-java/src/main/java/org/openrewrite/java/ChangeMethodInvocationReturnType.java

Using this recipe to correctly change response types based on the method, returning the following responses:

GetObjectResponse
GetBucketAclResponse
GetObjectAclResponse
GetBucketAccelerateConfigurationResponse
GetBucketLifecycleConfigurationResponse
GetBucketCorsResponse
GetBucketLoggingResponse
GetBucketNotificationConfigurationResponse
GetBucketPolicyResponse
GetBucketReplicationResponse
GetBucketTaggingResponse
GetBucketVersioningResponse
GetBucketWebsiteResponse

Additional changes:

• Map AmazonS3Exception to S3Exception
• Map BucketLoggingConfiguration to BucketLoggingStatus
• Revert converting CannedAccessControlList to ObjectCannedACL
  • We will leave as v1 POJO, and add comments in follow up PR to tell users to manually change to the appropriate v2 enum based on the method used, i.e. BucketCannedACL or ObjectCannedACL
• Replace BucketName with Bucket in getter methods (already in place for setters)
• Transform getBucketLocation() to append locationConstraint().toString() as v1 returns the String region

Testing

Added end to end tests

[zoewangg]

Can we update it to return a variable?

[davidh44]

Its covered it in S3RequestConstructor

aws-sdk-java-v2/test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven/after/src/main/java/foo/bar/S3RequestConstructor.java

Line 264 in 157dd10

String region = s3.getBucketLocation(GetBucketLocationRequest.builder().bucket(bucketName)

[zoewangg]

Can we follow https://github.com/aws/aws-sdk-java-v2/blob/master/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/nrs/HandlerSubscriber.java#L33 (provide time and link to the exact commit)

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE